chore: remove enzyme tests #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
force-pushed
the
remove-enzyme
branch
from
9213f9c to
d589076
Compare
rurikoaraki
approved these changes
Jan 29, 2025
rurikoaraki
reviewed
Jan 29, 2025
rurikoaraki
reviewed
Jan 29, 2025
rurikoaraki
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Enzyme has been deprecated / not compatible with the latest React versions, but we still have many tests running using it. As far as I can tell, there is no replacement for the types of tests we're running (
checkRenderConsistencyandcheckReRender), since the replacement (react-native-testing-library) is more of an integration test library. Let's remove the enzyme tests altogether, and port the ones that are simply snapshot tests to usereact-test-renderer.Note,
react-test-renderer(used for all our snapshot tests) is also deprecated, but it looks like react-native-testing-library v14 will have a replacement. So I'll hold off migrating those snapshot tests till we need to.Verification
CI should pass
Pull request checklist
This PR has considered (when applicable):